Skip to content

fix suggestion causes error of needless_for_each #15262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

fix suggestion causes error of needless_for_each #15262

merged 1 commit into from
Jul 15, 2025
+32 −9

Conversation

relaxcn
Copy link
Contributor

@relaxcn relaxcn commented Jul 12, 2025 •
edited by rustbot
Loading

Fixes: #15256

changelog: fix suggestion causes error of [needless_for_each] when the body.value comes from macro expansion.

@rustbot
Copy link
Collaborator

rustbot commented Jul 12, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 12, 2025
Jarcho
Jarcho requested changes Jul 14, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jul 14, 2025
@relaxcn relaxcn force-pushed the needless_for_each branch from 68ee73a to 87e64f6 Compare July 15, 2025 02:58
@relaxcn relaxcn force-pushed the needless_for_each branch from 87e64f6 to c20faa0 Compare July 15, 2025 03:02
@relaxcn
Copy link
Contributor Author

relaxcn commented Jul 15, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jul 15, 2025
Jarcho
Jarcho approved these changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Jarcho Jarcho added this pull request to the merge queue Jul 15, 2025
Merged via the queue into rust-lang:master with commit 0bf4d5a Jul 15, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarcho Jarcho Jarcho approved these changes

Assignees

@Jarcho Jarcho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

needless-for-each expands macros in suggestion
3 participants
@relaxcn @rustbot @Jarcho